Milad Mohammadi

Results 95 comments of Milad Mohammadi

After disabling the following flags, the tests continue to function without breaking. @Krovatkin I think we have a bug that only shows itself in debug mode. ``` export XLA_IR_DEBUG=0 export...

@thisisalbertliang can you take a pass at this issue please?

This PR doesn't build at the moment because the upstream layer LTC doesn't yet have API support for `expand` with `SymInt`. @JackCaoG @Krovatkin

Update: The current unit test checks the `expand.SymInt` code path. It does not check the dynamic dimension propagation across a `SymInt` op since `DimensionNode::isDynamic` implementation is currently WIP. CC @JackCaoG...

Here is the reference to [is_dynamic_dimension](https://github.com/tensorflow/tensorflow/blob/f518b5de7276ee81f244a3b4aaab9b760482db31/tensorflow/compiler/xla/shape.h#L82-L84).

Local tests pass for `python ../test/test_view_ops.py -v TestViewOpsXLA.test_view_copy_xla` as shown below, though they fail on CI. ``` 2022-08-07 23:30:32.889533: W 1463191 tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1:...

We need upstream support for this feature: https://github.com/pytorch/pytorch/pull/82188

@wonjoolee95 [this change](https://github.com/pytorch/xla/commit/15f12393df9ca4d46ea71a2eeda857942790faee) is breaking test in this CI.

Turns out the absence of -Wno-c++11-narrowing breaks pytorch tests and the absence of -Wno-c++14-narrowing breaks the pytorch/xla build. So, I added both flags and this seems to be working!! CC...

Turns out this problem has existed with the current pin (i.e. commit `6f5fd0d7199b9a19faa` in googletest version `1.10`) for quite some time ([ref](https://stackoverflow.com/questions/69935158/dummy-may-be-used-uninitialized)). The solutions is to upgrade to version `1.11.0`....