Mike Tonks
Mike Tonks
Could be duplicate of https://github.com/smartystreets/goconvey/issues/566 It's not a panic, just printing out stack trace on failure. Probably this should be optional, and default to off.
I agree the new behavior is not what we want here. I did a PR for this keeping the new behavior as an option, see: https://github.com/smartystreets/goconvey/pull/588 But not response in...
+1 We are using jenkins to automate test runs. A command to export the pretty html report as a file would integrate nicely.
Seems like this should not be too hard to implement, but then the web ui uses quite a lot of javascript so that may be a problem. Still think it...
+1 this is causing problems for us.
I added a pull request for this: https://github.com/compose/governor/pull/21
I submitted a pull request for this change: https://github.com/compose/governor/pull/20
Digging a bit deeper, it looks like go-git defaults to using the http.DefaultClient here: https://github.com/go-git/go-git/blob/bf3471db54b0255ab5b159005069f37528a151b7/plumbing/transport/client/client.go#L19 but it is possible to override the transport as per example here: https://github.com/fluxcd/source-controller/blob/2dc713258d3c4cae91923dc9689e6b468de1d54e/controllers/gitrepository_controller_test.go#L306 So it...
Yes totally agree. The git fetch probably makes multiple requests where connection reuse would be useful. Just needs to be configurable so we can set it below the poll interval.
Hi Mark, Bump: I think my last commit should close this issue, and give us a release candidate?