Mike O'Donnell

Results 125 comments of Mike O'Donnell

I think the focus outline may be the incorrect color, would think it should be white both for the title and for the logo

- [ ] Incorrect overlay opacities for phone - according to the specs, quartz light/dark should be 0.2 and high contrast should be 0.3. Same for most dialog overlays, not...

- [ ] Breadcrumb overflow menu should be a dialog/popover on mobile, so we'll need a new example for that, also the menu should be compact for the existing example

- [ ] I don't think this compact/cozy hybrid is in the designs ![Screen Shot 2022-07-01 at 10 38 53 AM](https://user-images.githubusercontent.com/2471874/176935633-addfa0ec-6e0d-440c-8594-73ff91b01e6a.png) - [ ] header title should have `--sapFontHeader5Size` -...

> * [ ] remove deprecated code or code we don't use This code I brought over from ngx: https://github.com/SAP/fundamental-styles/pull/3708/commits/9c813fc6d686287b87fb08ea076af804d5b9c474 The class isn't used anywhere in styles or ngx but...

> * [x] Select (Horizon) - the focus for the menu elements (first and last element) should be consistent with the Menu and List. Same issue on multi-input and combobox....

- [x] Upload collection with long text - save/edit buttons get vertically stacked **won't fix** ![Screen Shot 2022-06-02 at 11 40 46 AM](https://user-images.githubusercontent.com/2471874/171692539-5381d5e6-75a8-4224-b422-3e604854b4cc.png)

- [x] tool header - button edges are cut off https://github.com/SAP/fundamental-styles/pull/3515 ![Screen Shot 2022-06-03 at 10 16 44 AM](https://user-images.githubusercontent.com/2471874/171905166-09ff7db5-82fd-424d-a65b-9ea38c2d488f.png) ![Screen Shot 2022-06-03 at 10 16 47 AM](https://user-images.githubusercontent.com/2471874/171905171-35fe1ba5-1a9b-4aa6-be33-7d1a24ed63f3.png)

- [x] shellbar - popover not aligned (all themes) ![Screen Shot 2022-06-03 at 11 40 10 AM](https://user-images.githubusercontent.com/2471874/171917710-a39d0355-4311-4130-9079-5dbef3bc84cc.png)

- [x] Horizon icon tab bar is missing separators also causing broken focus outline on menu item https://github.com/SAP/fundamental-styles/pull/3518 fiori: ![Screen Shot 2022-06-03 at 12 21 21 PM](https://user-images.githubusercontent.com/2471874/171923597-0982b577-7211-4f84-a0b5-755cfd876a28.png) horizon: ![Screen Shot...