Mike Burke

Results 4 issues of Mike Burke

[SystemRequest](https://github.com/smartdevicelink/sdl_android/blob/master/sdl_android_lib/src/com/smartdevicelink/proxy/rpc/SystemRequest.java) includes support for legacy `encodedSyncPData`, but it isn't handled very well. There is simply an [extra constructor that takes in a boolean](https://github.com/smartdevicelink/sdl_android/blob/master/sdl_android_lib/src/com/smartdevicelink/proxy/rpc/SystemRequest.java#L20-22), ignores the boolean value and assumes the...

bug
rpc

[From ProtocolMessage.java](https://github.com/smartdevicelink/sdl_android/blob/5a9cc2c6067a6063a1e1441a0c0194ca4215cf2a/sdl_android_lib/src/com/smartdevicelink/protocol/ProtocolMessage.java#L46-52). ``` java public void setData(byte[] data, int length) { if (this._data != null) this._data = null; this._data = new byte[length]; System.arraycopy(data, 0, this._data, 0, length); this._jsonSize = 0;...

bug
protocol

ByteEnumer and all subclasses have the exact same behavior as enums, they are defined in an "enums" package, but are not actually enums, they are classes being treated like enums....

best practice
protocol

The current libraries don't follow best practices for handling exceptions. Here is a good guide for [Java Exception best practices](https://code.google.com/p/solidbase/wiki/ExceptionHandlingGuideline). For example, SDL only has defined a single custom exception...

best practice