mikeberesford

I'd add that if the call order is required and changing the public API isn't possible, the API should probably enforce the call order - once linkToDbNative is called, calls...

@kcudnik @JaiOCP @marian-pritsak @rlhui any continued thoughts on how we might handle this would be appreciated.

Introduce another attribute? On use-case to set speed+fec together, then set speed and fec, then set attribute to false. Effectively start limited transaction (just for speed and FEC)

Perhaps I'm missing something, but I'm not seeing a bulk set API defined for port attributes in the SAI interface. If we do have something like that available, I'd be...

I agree that consistency is the problem here. With the current implementation, my understanding is that on non-\_WIN32 systems `SAI_STATUS_IS_INVALID_ATTRIBUTE(SAI_STATUS_NOT_EXECUTED)` would evaluate to true, which seems like it's not the...

Are there thoughts on how we can close this out?

I don't know the history, though by some conventions Unix-like systems use negative values for error. That said, I don't see a reason these couldn't just all be made positive...

I think what you're suggesting is changing: ``` #define SAI_STATUS_CODE(_S_) (-(_S_)) ``` to something like ``` #define SAI_STATUS_CODE(_S_) (_S_) ``` and perhaps changing sai_status_t to be UINT32 to prevent issues...