Mike Jumper

I'm not against altering things such that things work cleanly even if you attempt to copy data that Guacamole itself does not currently handle, but I don't think this is...

Thanks, @akallabeth. We don't normally cover multiple JIRA issues with a single PR. If these changes are distinct enough that they warrant three separate JIRA issues, the changes for those...

@allquixotic, please use the dev@ or user@ mailing list if you have questions: http://guacamole.apache.org/support/#mailing-lists There are no known issues with the behavior you describe, and it's unlikely that what you...

I'm not sure about this approach. There has to be some scope and design behind the creation of a library. I agree it makes sense to extract a common core...

> I think this is a starting point, and we need to think about how to make this modular. Do you or anyone on the team have ideas of how...

> I did not find any references to the old constants: ... I think I found them: https://github.com/apache/guacamole-client/blob/881d203080009c3a8827c602c1f6d314f30a67b7/guacamole/src/main/frontend/src/app/client/types/ManagedClient.js#L429-L468 > That said, the frontend does contain the ManageedClientState.js file, which implements...

There are a number of commits here which are not from GUACAMOLE-660:  as well as a merge commit:  The only commits here should be those related to your...

OK - things look generally good code-wise, but I'm seeing a few issues when testing this new support. Most appear to be unexpected results of RTL text. 1. The icon...

Also, just ran the translation checking script added via #356 against the Urdu translation: ``` The following strings are either NOT defined for the original language or are expected to...

Ah, yes. That gif captures the feeling of refactoring so perfectly.