Mike Aksarin

icon indicating a website link linked.in/mike.aksarin

icon location Scala engineer. Eager for peace, humanity, beautiful mind and beautiful code that is clean, safe, concise, smelling good, easy to read and to evolve

Results 3 comments of Mike Aksarin

Refactor NetworkController and PeerManager actors

Do we have heavy operations in Peer Manager that could block NetworkController if we made them single actor?

Unclear logic in NetworkController initialisation

Then we don't need `(settings.upnpEnabled && myAddrs.exists(_ == upnp.externalAddress))` check and `NetworkInterface.getNetworkInterfaces.asScala.exists` should be `NetworkInterface.getNetworkInterfaces.asScala.foreach` By the way `myAddrs.exists(_ == upnp.externalAddress)` is never `true` as `upnp.externalAddress` is `Option` and it...

Rework all Actor's tests

We also can get rid of TestKit usage if we use TestProbe