Mihir Bhansali

Results 8 comments of Mihir Bhansali

▶ test runner output (4860.751ms) ℹ tests 47 ℹ suites 1 ℹ pass 44 ℹ fail 0 ℹ cancelled 0 ℹ skipped 3 ℹ todo 0 ℹ duration_ms 4870.7587 node:assert:173...

> @mihir254 according to the CI, there may be a merge conflict in the dot reporter > > ``` > 08:07:52 CONFLICT (content): Merge conflict in lib/internal/test_runner/reporter/dot.js > ``` How...

Is there a windows version of `make lint-js-fix`? I tried `.\vcbuild lint-js-fix` but it is not a valid command line option. Also, `.\vcbuild lint` only lints the markdown files on...

``` running lint-js Oops! Something went wrong! :( ESLint: 8.57.0 C:\Users\........\node\tools\node_modules\eslint\node_modules\eslint:1 .. ^ SyntaxError: Unexpected token '.' at wrapSafe (node:internal/modules/cjs/loader:1378:20) at Module._compile (node:internal/modules/cjs/loader:1435:41) at Module._extensions..js (node:internal/modules/cjs/loader:1555:10) at Module.load (node:internal/modules/cjs/loader:1288:32) at...

Are some of the tests (like test-macOS, etc.) failing because they are expecting the original dot-reporter response? How can I go about fixing them? Also, still no luck with linting....

I see that `test-runner-reporters` keep failing as it expects to see `.XX.` instead of the updated `dot-reporter` output. The expected values are hard-coded in the test. How should I go...

I think the `parallel/test-runner-reporters` still needs to be fixed. ![image](https://github.com/nodejs/node/assets/52945500/3664638c-829c-4ca6-8b0c-38b391d1befd) It does not expect to see the failing tests (test/parallel/test-runner-reporters.js line 84). Any directions on that?