Miguel Pires
Miguel Pires
Hi. Is there a spec for this (or any discussion about this change)?
Closing since these changes were merged in https://github.com/snapcore/snapd/pull/12087
Thanks for this. I did an incomplete pass and have some questions. I'll go over the parts I didn't read once I re-review
Hey @sergio-costas, is this ready for a re-review? I see a few unanswered comments so I'm just checking before going through it again
> @MiguelPires Ops! I clearly forgot some of them. Give me some minutes to end another thing, and I will fix them. No worries, take your time :slightly_smiling_face: I'll re-review...
@mvo5 should we close this for now? It seems like this needs another look and we don't have the bandwidth right now
I've been thinking about it and I think we should revise how the API looks in general. The way we do method chaining has the nice advantage that it forces...
I rebased this on master since we've since merged the changes this PR made to `transaction.go` and `registry.go`. It should make this diff much smaller
Closing as this has been split/reworked into several other PRs
There's an issue in the invariant check but should be simple to fix. I'll do it next week and ping for reviews again