Miguel Vilá

Results 22 comments of Miguel Vilá

@gr2m thank you, I think I tried that, but the format wasn't the correct. I was probably trying a JSON.

we use `ModelDiff` and `ChangedShape`. The issue with `ChangedShape` is that it doesn't tell use what specifically changed, only the old and new shape. We figure out the difference on...

@Xtansia I have addressed most of your comments, the remaining one is regarding using an import instead of the fqn for `java.util.Objects`. Not sure how to do that. I'm also...

@Xtansia I would prefer not to add those manually, but not sure what would be the changes needed to include them in the codegeneration. Locally, I modified the `OPERATION_MATCHER` constant...

@JuditKnoll thank you, I've added a couple of simple tests, you will notice I had to make a change in order to make this testeable. I'm not familiar with bcel,...

@hazendaz it was true but it was not reading the system property. I think the `reportAll` change is not enough to make this work and that's why I modified `checkRefComparison`...

@JuditKnoll @hazendaz let me know if this looks good or if there's anything to address

hi, any update on when this can be merged and released?

@hazendaz hmmm, I assume your concern is that this doesn't have the same behaviour as the previous code? So in order to preserve the default behaviour before (around `if(reportAll)`) we...

looked into this. By making the variable have a default value of true, this error surfaced: ``` Exception analyzing edu.umd.cs.findbugs.FindBugsCommandLine using detector edu.umd.cs.findbugs.detect.FindRefComparison java.lang.IllegalArgumentException: Invalid class name edu/umd/cs/findbugs/config/AnalysisFeatureSetting[] ... ```...