Michal Habera

Real element is not like `QuadratureElement` or any `BaseElement` subclass because it does not have local basis. In old dolfin such element would export `num_global_dofs` in the generated ffc code...

I do not see any. Just `XDMFFile::write_meshtags` must be made templated and header-only then. With proper `write_meshtags_int32`, `write_meshtags_int8`, etc generated in pybind and automatically dispatched based on datatype in python...

What is the parallel ownership of real element dofs? For performance reasons we could pack coefficients of Real element in a similar way to how Constants are packed - outside...

We are trying to avoid to have too many paths and ways how to change parameters (dolfinx and ffcx). It is very annoying to have to check all levels of...

This PR avoids touching filesystem with pugi XML file on every `write_foo` call (beneficial in timeloops). It does so only on explicit `.close()` or `.flush()`. Barriers are needed only is...

I only observe this when using `-Ofast`, i.e. `-ffast-math`. For `-O3` no missing symbol issues. The typical error is `ImportError: /root/.cache/fenics/libffcx_forms_ef6d1600eef81c98b3d6319ebc286a08d493b291.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZGVdN4v_exp`. `_ZGVdN4v_exp` is a SIMD version of...

Is linking against `libm` always safe? Maybe we can add it as a default, any experienced user would link against his math library himself.

Why is it needed to `#define` some `int`? Placing it into a member variable of our static struct wouldn't work with SYCL?

Substitution `CellAvg(u) --> u / CellVolume` does not look correct to me, these things have also different units (u-units vs. u-units/volume). And it is also wrong for constant functions, since...

Yes, the correct implementation of entity averages requires an integral within integral. Unfortunately, FFCx is not flexible enough for this at the moment. This should become easier once we have...