Michael Peter
Michael Peter
This is not a full review, but a few things jump out at me in an initial pass. I recommend fixing these issues while you investigate your Travis build errors...
Thanks for making the updates. I have added it to my queue, and will give it a full peer review today.
Heard. Reviews still take time. I assure you I am working on your PR.
Friendly reminder to squash your commits if you want this merged tomorrow
Given the number of known mistakes in the CLI commands, we need QE reapproval before we can move forwrad on the merge.
The build looks good. There are still some typos in the `oc get` commands, where there is no space between `-ojsonpath` and no closing quotes to the end. I will...
@sbeskin-redhat Thanks for asking for a re-approval from QE. I am removing the hold, since I am not on the peer review squad this week and won't be checking GitHub...
The typos were in the CLI commands, so they were not about semantics or formatting. That is why QE verification was requested. For example, `$ oc get route -n -ojsonpath="{.spec.host}`...
@mperetzred: If you would please verify that `$ oc get route -n -o jsonpath="{.spec.host}"` is correct, I think that we can move forward. @sbeskin-redhat: Please squash your commits when you...