Michael Nebel

Results 65 comments of Michael Nebel

DCA tests have executed. (1) Performance of nightly queries show no performance regressions or change in alerts. (2) Performance of capture model show no performance regressions, but a significant change...

(1) DCA for nightly looks fine. No problem with query execution. (2) DCA run for the Models as Data queries themselves hit an OOM exception. This should not block merging...

> (1) DCA for nightly looks fine. No problem with query execution. (2) DCA run for the Models as Data queries themselves hit an OOM exception. This should not block...

The linked documentation states ```doc By convention, controller classes: (1) Reside in the project's root-level Controllers folder. Inherit from Microsoft.AspNetCore.Mvc.Controller. (2) A controller is an instantiable class, usually [public](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/public), in...

> Microsoft.AspNetCore.Mvc.Controller Alright. I am not well versed in ASP.NET. I can see that the zipped source contains HomeController and TestController. What you are saying is that these are "real"...

> Correct. Added another comment on a possible side effect of derived remote flow sources. This Controller suffix requirement needs more scope of the remote flow source code will also...

> I have added the tests. There are two issues though: > > 1. The code https://github.com/github/codeql/pull/9406/files#diff-19ef3a656171752739b8876631ea7527435a6bf09eaa8b1ab2e7664e3fe9c0bfR199-R205 makes sense in prod, but doesn't work for tests because there are no...

@JarLob : Are the pushed changes aligned with your thinking on the topic?

No problem - happy to help. 👍 The following needs to be done: - Rebase the PR as things has changed in some of the surrounding code. - Make a...

> What is DCA and how to run it? DCA or Dist Compare Action is our test tool. It allows us test for performance regressions and new/missing alerts and much....