Michael M.

Results 34 comments of Michael M.

@The-Compiler I just checked back on this and I don't know why those two tests are failing; they don't look like they're related to this PR. If they're unrelated, then...

@toofar Thanks for the feedback! I'm pretty new to the codebase so those file paths and usages of yanking were useful. I just added another commit that uses the new...

@toofar I just pushed added a new commit to use `{url:yank}` instead. I agree, it looks much nicer than `{yank_url}`. I also like having the word "yank" in there so...

@The-Compiler I've added those improvements. I agree, using keyword arguments is probably better. I think everything should be all good/ready now.

@The-Compiler Any update on this? Do you think this is ready to merge?

@The-Compiler Checking back on this a few months later. Is this PR still useful and/or in a good to merge?

@peterjc Could you review this PR too?

@mdehoon Any thoughts on this PR?

Just checking in on this again: @corneliusroemer does this PR fix your issues?

@corneliusroemer Checking in a few months later, did this PR fix your issue?