Martin Hujer

The spaceless tag is deprecated since Twig 2.7, use the spaceless filter instead

5

With a recent version of Twig I'm getting a deprecation warning because the use of the [`spaceless` tag](https://twig.symfony.com/doc/2.x/filters/spaceless.html) in the template: https://github.com/whiteoctober/BreadcrumbsBundle/blob/78214890393fa5dd9cea632873ee10e0a290b33b/Resources/views/microdata.html.twig#L1-L3 It suggests to use [`spaceless` filter](https://twig.symfony.com/doc/2.x/filters/spaceless.html) instead. But...

class-string vs literal-string in QueryBuilder

13

With the [recent addition of literal-types to QueryBuilder](https://github.com/phpstan/phpstan-doctrine/pull/327/files#diff-197b8a38b2ae878d60d27968735dd0b7208e015f401be1b2c5761add8fe8b85dR61) (https://github.com/phpstan/phpstan-doctrine/pull/327), I'm getting warnings when passing `class-string` there: `Parameter #1 $from of method Doctrine\ORM\QueryBuilder::from() expects literal-string, class-string given` This is the simplified...

This is not a bugfix but rather just a bug-reproducer. I stumbled across this when testing a class that add extra conditions to a provided Query Builder. ``` Strict comparison...

AssertEqualsIsDiscouraged

5

This rule is even more opinionated than the previous ones. If you don't think it should be included in PHPStan, I can change it and keep only the first part...

Ideas for additional strict rules

5

Here is a list of a ideas that may be implemented in the future: - [ ] suggest `assertInstanceOf(Foo::class, $a)` instead of `assertTrue($a instanceof Foo)` - [ ] suggest `assertNotInstanceOf(Foo::class,...

RegExp wrapper for preg_replace

1

Consistence already provides [a wrapper](https://github.com/consistence/consistence/blob/3334e6bd8babfa444cc20e77233b81b4e73fb886/src/RegExp/RegExp.php#L22) for `preg_match` which checks return value and throws an exception, if the error value is returned (so you don't have to check it each time...

Does not work on Windows + cygwin (php/js)

13

js file with error: ``` $ git commit -m "a" on branch master --> jshint syntax checking for test.js stdin: line 1, col 1, Expected an assignment or function call...

Coding standard does not specify negation formatting

3

Currently the negation formatting is not explicitly specified in the standard. It can be written either: - with no spaces `if (!is_array($foo))` - with space after `if (! is_array($foo))` -...

https://github.com/consistence/coding-standard

Display only errored files in standard run