mhn65536

Results 9 comments of mhn65536

I'd prefer it not do anything the VisualStudio "Format Document" command doesn't. In the end, you want me to fix my own code as long as i'm around. If you...

I'm still not entirely sure, what this will accomplish. I can see a lot of really badly formatted code in the project yes. But formatting it "nicely" will not make...

The asm most likely does what it claims to do. I'd prefery if the additional code would be always written to the rom. That way we only have to deal...

Does the cur_map reset if you go back to the overworld? There's a flag that makes marsh and dessert tiles do damage on the overworld. if cur_map doesn't reset, you...

It's your call about Flame Armor, Shield, Resistances. You can always change your mind later. If you want more opinions, just ask on the dev discord.

What highqualityshawn kind of wanted to hint at is that if (Spells.Where(spell => spell.IsAoEAttack()).Count() < 1) isn't the simplest method of doing what you want. It would probably be easier...

Also please don't change line endings or reformat whole files if you can help it. It makes reviewing changes very hard.

I'll explain how the code works. If you randomize item magic and for example pick "support" magic as the pool, then there will be 42(including duplicates) Spells in the pool....

Yes, but the Support Pool does not include InflictDamage spells, only InflictStatus and Buffs. But Spellcrafter is pretty much guaranteed to generate at least one AoE InflictStatus.