mhkadhum

Results 6 comments of mhkadhum

Thanks for the feedback! ive added the missing license headers and ran `pre-commit` locally, and pushed an updated commit

> looks generally good @mhkadhum , thanks for the contribution. Will you be maintaining this? As it is a 3rd party component and it may require hardware or licenses not...

Hi, @DaanHoogland @abh1sar Just made the Update talked about in my previous comment with @DaanHoogland The screen displays the token creation request, which responds with the token and expiration details...

Hello @abh1sar @DaanHoogland I just wanted to quickly follow up on my last comment. I understand u r probably busy but if u get a chance, could u take a...

> > Hello @abh1sar @DaanHoogland I just wanted to quickly follow up on my last comment. I understand u r probably busy but if u get a chance, could u...

> Reviewed EcsObjectStoreDriverImpl Overall functionality looks good but there are some comments on code maintainability and organisation. Please check. Overall, I think use of reflections can be avoided in most...