mheyse
mheyse
Hi, thanks for the review. > * Could we eventually wrap all the Modbus into `#define's` so we can have CI do a special build for ESP32S3's (or any dual-core...
Hi, the Modbus interface currently seems to do what I want it to do - reading and writing entities works in my tests as expected. The two big things missing...
Can you tell me where you get the compile error, is it in `test.cpp`? I assign lambdas to auto vars there, but when I build here (I usually do a...
Regarding the config UI: The parameters that should be configurable are defined at the beginning of `modbus.cpp`: ``` // parameters bool Modbus::modbus_enabled_ = true; uint8_t Modbus::systemServerId_ = 1; uint16_t Modbus::port_...
So now I'm confused does it compile or not? :-) I can try it on Ubuntu, too, if needed. Then I'll reverse the auto -> std::function commit? Re. settings, yes,...
I didn't have time to look at it until now - I had to move to a Windows PC from Mac, and now I can't get the firmware to build...
OK I added `pre:scripts/build_interface.py` to the `extra_scripts` in the `[env:ci]` section I'm usually building and now it works again, so something seems to be broken in `platformio.ini`. (A plain `pio...
no I don't. FWIW, I first ran `pio run -e ci` and after that failed `pio run`. I pushed my changes after rebasing to current dev. One question: you removed...
(same with the `EMSdevice:DeviceType`)
Yes, it should be a esp32_16M (I'm using a BBQKees E32 Gateway V2). Regarding the enums I'm using: - The `DeviceType` is mapped directly to the Modbus server ID (as...