Matias Grunberg

Results 16 comments of Matias Grunberg

@wpolicarpo I created PR https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/869 to explore this possibility. I found some issues.

Some info I gathered while working on the issue https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/859. `insert_all` semantic is "skip on duplicates". [ActiveRercord validates](https://github.com/rails/rails/blob/v6.0.3.6/activerecord/lib/active_record/insert_all.rb#L20) that the database adapter supports "skip on duplicate" when you call `Model.insert_all`,...

@k0va1 thanks for the PR. Would you add some test? Maybe [here](https://github.com/activeadmin/activeadmin/blob/master/features/index/formats.feature) is a good place. Also, would you make the PR against the default branch? We can backport the...

@henrikbjorn thanks for opening the issue. PR #8225 fixes this.

> @javierjulio Actually, this was supported in version 3. Take a look at the following snippet in the `menu.feature` spec: > > ``` > Scenario: Adding a resource as a...

@javierjulio have you considered keeping the content of current docs (v3)? This has two pros: 1) Users will be able to access old versions doc. Something good until they manage...

> @mgrunberg I extracted the general updates that were version independent #8424 and merged that in. Let me know if you are still interested in trying something out for docs...

@javierjulio, @tagliala is it too premature to do this now? Considering we are working on a major release.

I added the TargetRubyVersion. Thank @tagliala for the suggestion. @javierjulio are we good to merge the PR now?