Martijn Govers

Results 115 comments of Martijn Govers

My expectation is that it will not be straightforward to add this without introducing a significant memory overhead unless we have the columnnar data format mentioned in #548 , but...

Again: thank you for creating the PR. It looks quite good at first sight. I've already started going over this PR, but something else came up. Will continue with the...

> One test failed, but we have no control over it: > > > > > > ************* Module power_grid_model.validation.validation /opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/power_grid_model/validation/validation.py:1:0: C0302: Too many lines in module (1001/1000) (too-many-lines) Hi...

> @mgovers My proposal is to add a linter exception for this file? To refactor the whole validation function is out of the scope. Thank you @TonyXiang8787 for picking that...

would the parent repo structure remain the same? e.g. ``` - tests/data/ - power_flow/ - modeling_validation/ - error_handling/ - ... - state_estimation/ - ... - short_circuit/ - ... ``` and...

hi @WinApiMan, Thank you for reporting this. Can you try to load the data into Python and use the data validator (https://power-grid-model.readthedocs.io/en/stable/user_manual/data-validator.html)? This may expose some basic usage problems that...

FYI, I've been able to reproduce the `SparseMatrixError` and I also confirmed that our data validator does not signify any errors. We will dive into this now.

Thank you for your extensive input, it really helps with the investigation. This indeed seems something that requires a deep-dive on our end. We will investigate.

@WinApiMan ~Awesome, that's great to hear!~ EDIT: I mis-read. That's unfortunate. See below for continuation. Thank you for your patience. It took us some time to come up with a...

> [@TonyXiang8787](https://github.com/TonyXiang8787), [@mgovers](https://github.com/mgovers) . We used the last pgm version 1.12.69. The sparse matrix error didn't disappear. > > Files > > [calculate_model_1.json](https://github.com/user-attachments/files/23647264/calculate_model_1.json) > > > Additional test > >...