Martijn Govers
Martijn Govers
> @mgovers It is far from finished. I just put here to see what you think. The tap position optimizer, we still need to make it compile with mocked `meta_data`....
> @mgovers it's now ready for review will have a look > ## [](https://sonarcloud.io/dashboard?id=PowerGridModel_power-grid-model&pullRequest=587) **Quality Gate passed** > > Issues  [18 New issues](https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&pullRequest=587&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&pullRequest=587&resolutions=WONTFIX)...
out of scope of this ticket but we may need to version bump sonar: 
> > out of scope of this ticket but we may need to version bump sonar: > >  > > Do we just have to modify like this? https://docs.sonarsource.com/sonarcloud/advanced-setup/languages/c-c-objective-c/#executing-the-analysis...
It is possible that MacOS needs an additional feature flag before we can use this feature: https://github.com/PowerGridModel/power-grid-model/actions/runs/8570641564/job/23489029489 Note that according to https://en.cppreference.com/w/cpp/compiler_support/20 , the XCode version we use in CI...
Conclusion of discussion: * Edge cases like this are rare in real grid scenarios. * They can theoretically happen for generators but we don't expect them to. * It is...
As discussed: we will solve this in a different way
current functionality clamps the tap position: https://github.com/PowerGridModel/power-grid-model/blob/09ee5a6e3a65d21cb2d0dbc8bc18b29ecc405c5f/power_grid_model_c/power_grid_model/include/power_grid_model/component/transformer.hpp#L145-L149 (and idem for 3w-transformer). this existing behaviour may impact users. if we decide that existing functionality is good enough, documentation should be improved
I do agree that the current state (and mainly the syntax) makes it less readable and testable. I propose going with Proposal 2 with a slight modification: ## Argument against...
> @mgovers how far are we close to merge this? Cfr. our discussions, we run the benchmark case and if the amount of fill-ins is the same for both implementations,...