Mostafa Ghoneimy

Results 16 comments of Mostafa Ghoneimy

So there are a few things we need to do now: 1. Research how query parameters and variables are formatted in the query string in GET requests: This library converts...

Can you please provide with a link to a GraphQL server that receives responses in GET requests?

For the time being, users were prevented form being able to use any request type other than "POST" with release 1.9.2 https://github.com/mghoneimy/php-graphql-client/releases/tag/v1.9.2 Let's work on a pull request to enable...

being addressed by #53

Hi @bbaga , Let me take a look at the code tonight and let you know what I think tomorrow. But until I do I have a concern I'd like...

I took a look at the code. The change can definitely be made to replace the hard dependency on GuzzleHttp to become a dependency the PSR-19 inerface, and it should...

I just wanted to note that to me, it seems like the constructor signature change is more of a backward compatibility problem than the composer file as we'll need to...

Ah gotcha! I like this suggestion, it makes more sense than what I proposed earlier. Will wait for your pull request when it's ready :v:

Hard dependency on Guzzle will be totally removed in the next major version release because it is backwards incompatible

@Doqnach I don't have a strict timeline tied to this, but it's going to be included in the next major release as this change will lead to some backward incompatibly....