Lene Gadewoll

Results 57 comments of Lene Gadewoll

This has already been fixed some time ago in this [PR](https://github.com/elastic/eui/pull/7062) (see the exact change [here](https://github.com/elastic/eui/pull/7062/files#diff-3d6b40d828b6e3fd84b57a6db49aa0ae7aed90133e45860683e4bf4084408841R35)) 🔗 See the current released EUI docs [here](https://eui.elastic.co/#/display/description-list#inline). ![Image](https://github.com/elastic/eui/assets/44670957/24a7cd82-c442-43d2-9e8a-ae4ba6d48538)

đŸ—’ī¸ I added VRT snapshots to this PR but the initial state of the tooltip story is equal to the playground one. We should add interactions to create a different...

> Hey Lene! I'm so sorry for not reviewing this in time for Monday's release - I'm leaning towards shipping with just the combobox tooltips for this week and getting...

@cee-chen Thanks for the changes! The updates look good to me 👍 I'm fine keeping the function component conversion in this PR - it's not part of the scope but...

🗒 One side note on this topic: When allowing using it as any element, there is the added responsibility to ensure valid HTML structure on implementation side. We might want...

@tonyghiani Those are good points! > Is there any specific reason why we should always use the EuiFlexItem, apart from when we need flex behaviours (stretch, grow) on its content?...

> FWIW This is the typing shenanigans I mentioned briefly in our sprint planning on Monday that I anticipated being a potential issue 😅 In theory we could solve it...

> I'm not against updating `EuiText`, `EuiHeading` and `EuiScreenReaderOnly` (the primary culprits for components that cloneElement / _require_ a nested inner element) to simply use a `component` or `as` prop...

â„šī¸ I added baseline VRT references for `EuiComboBox`. The tooltip story currently looks the same as the playground one, I want to update it to use interactions to show an...

This upgrade updates internal dependencies only, see the changes [here](https://github.com/theKashey/react-focus-on/compare/v3.9.1...v3.9.2). **Dependencies updated**: - react-focus-lock: `^2.9.4` -> `^2.11.2`, ([changes](https://github.com/theKashey/react-focus-lock/compare/v2.9.4...v2.11.2)) - react-remove-scroll: `^2.5.6` -> `^2.5.7` ([changes](https://github.com/theKashey/react-remove-scroll/compare/v2.5.6...v2.5.7)) - react-style-singleton: `^2.2.0` -> `^2.2.1` ([changes](https://github.com/theKashey/react-style-singleton/compare/v2.2.0...v2.2.1))...