mfedderly

Results 34 comments of mfedderly

We can probably bump geojson-equality's deep-equal dependency to ^2.0.5

@zt123123 can you explain more about what this PR is supposed to fix? Thanks!

Yeah I think splitting based on number of edges is a good solution, some amount of testing would have to be required to figure out what the inflection point is....

Similar objection here with the compiled code that wound up vendored https://github.com/Turfjs/turf/pull/2033#issuecomment-893682955

Same thoughts as https://github.com/turfjs/turf/pull/2033#issuecomment-1014898084 to go back to using the proper npm dependency.

I don't know of any other renames offhand, but I made a PR for lineIntersect https://github.com/Turfjs/turf/pull/2187

> @mfedderly There's a lot of casting happening in these additions. Is your intention that they should be accepted for this PR? So that it doesn't get too big chasing...

#1238 looks vaguely similar but does not cover the same thing as this PR. Looking forward to the feedback when you get the time.

@HarelM I updated the PR based on your feedback. A few flags: 1) `serialize()` is now not super useful for the updatable sources 2) The way we get feature ids...

Removing the requirement to have unique feature IDs in the input moved us further from the goal of initializing with setData and then being able to use updateData. One nice...