Gérald Barré

Results 77 comments of Gérald Barré

@MarcoRossignoli The CI completes with the preview package :) https://github.com/meziantou/Meziantou.Framework/runs/1717298953 Thanks for the fix! I'll wait for the official release to update coverlet in my project

@MarcoRossignoli The tests complete using the 3.0.2-preview.3 version :) https://github.com/meziantou/Meziantou.Framework/actions/runs/505978678

I've [merged the latest version](https://github.com/meziantou/Meziantou.Framework/pull/122) and it seems ok on my side 😊 Thanks for the investigation and the quick fix!

Indeed, the compiler move it to the setter ([sharplab](https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AXEBLANmgExAGoAfAAQGYACcgJmoEEBYAKAG83rvqBtcgIwA6ACLYAhgHMAdhADOGbGDlCAwhAIxG08bgCec7Csa5cEAO4A5AK6mAulx5VaAgAzUAQo+6dWPf9SSMBgA3NRywSHe1AC+bDFAA=)). This make sense as the attribute change the behavior of the `value` parameter (so only the setter). However, it seems not...

Currently, MA0002 check for `IComparer` and `IEqualityComparer` when `T` is `string`. If I well understand, you want to extend (a new rule or using a config) the rule to report...

It should be a different rule, disabled by default because it is specific and verbose. Do you think the rule should consider any overload with an additional `IComparer` parameter whatever...

I'm fine with this behavior. Would you like to submit a PR for this new analyzer?

https://docs.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendjoin?view=netcore-3.1

What do you think of this design? ````diff public class ConcurrentObservableCollection { + /// + /// Combine CollectionChanged events when possible (for instance, add/remove) + /// + public bool OptimizeEvents...

BeginBatch always send a Reset event. OptimizeEvents is another option, not linked to the batch. As events are dequeue on the Dispatcher thread, there can be multiple events (Add/Remove/Update). It...