Andrew Metcalf

Add missing DYNALIB_FNs for os_thread_{wait,notify}

1

### Problem ``` /Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:51: undefined reference to `os_thread_notify' /Users/andrew/.particle/toolchains/gcc-arm/10.2.1/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: ../../../build/target/user/platform-6-m/supply_ventilation//libuser.a(DisplayTask.o): in function `DisplayTask::_taskFun()': /Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:59: undefined reference to `os_thread_wait' collect2: error: ld returned 1 exit status ``` ### Solution Added missing...

Avoid freeing memory in detachInterrupt

1

### Problem When `attachHandler` is called with a function pointer (or a pointer to a member function and instance), it allocates a `std::function`. When `detachHandler` is then called on the...

### Problem The existing unit test stubs do not include a definition for `system_thread_set_state`. I'm working on unit testing a Particle project and the lack of this stub causes the...

### Problem Attempting to compile for unit testing using Clang fails due to differences in the math headers with the errors below. ``` ERROR: /Users/andrew/code/arduino-particle-bazel-demo/particle/src/BUILD:3:17: Compiling src/particle-bazel-demo.cpp failed: (Aborted): wrapped_clang...

Ignore files in lib directory during build

4

### Problem If the `lib` directory contains a normal file (in my case a Bazel BUILD file), local compilation with Particle Workbench fails with: ``` > Executing task: make -f...

performPendingErase already checks hasPendingErase so there's no need to document checking for a pending erase before requesting the erase: https://github.com/particle-iot/device-os/blob/0bc16d94772999c016aa4c70c1b330f53321f90f/services/inc/eeprom_emulation.h#L245

libev engine has inconsistent handling of signals that raise an exception on the main thread

8

When sending a signal that raises an exception (e.g SIGTERM) while waiting on a NIO `select` on the main thread, behavior is either: * Raise the correct SignalException * Fail...

State updates in ReactMixin are not atomic

13

Nuclear's current implementation calls [`reactor.observe` separately](https://github.com/optimizely/nuclear-js/blob/2e8b995269b2cb80298cac8ffadbcf8a6dc435b6/src/create-react-mixin.js#L27) for each entry in the response to a React component's `getDataBindings`. If multiple pieces of bound data change in a single dispatch, Nuclear will...

Fix confirmation button selector

1

The existing confirmation button selector here didn't work for me. I suspect the selector was using obfuscated values that change between release. I tried to come up with a selector...