Daniel Mesejo

Results 12 comments of Daniel Mesejo

If this is still open, I would like to take it.

The issue seems to have been resolved in version 5.1.0, it no longer raises any exceptions. **Code:** ```python import pandas as pd import ibis df = pd.DataFrame({'key': [1, 1, 2,...

@trivialfis Thanks for your fast replay! So, if I want to create a library to do inference using XGBoost models and be consistent with XGBoost, will the library only be...

The feature was not readily available in DataFusion, but it will be once this [PR](https://github.com/apache/datafusion-python/pull/824) is merged and released.

I think that simply implementing `visit_FirstValue` (or `visit_LastValue`) is not enough, since neither of those classes has an `ignore_nulls` field, see: https://github.com/ibis-project/ibis/blob/bb42a6bd090c5c500ca86303f37bfd66d05767c7/ibis/backends/sql/rewrites.py#L72-L79 So the first step would be to add...

List (not exhaustive) of backends that require `ignore_nulls` for `FirstValue` and `LastValue`: - BigQuery ([source](https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/navigation_functions#last_value)) - DuckDB ([source](https://duckdb.org/docs/stable/sql/functions/window_functions#last_valueexpr-order-by-ordering-ignore-nulls)) - Snowflake ([source](https://docs.snowflake.com/en/sql-reference/functions/last_value)) - ClickHouse ([source](https://clickhouse.com/docs/sql-reference/aggregate-functions/reference/last_value)) - Exasol ([source](https://docs.exasol.com/db/latest/sql_references/functions/alphabeticallistfunctions/last_value.htm)) - RisingWave ([source](https://docs.risingwave.com/sql/functions/window-functions#first-value-and-last-value))...

@cpcloud, Thanks for the review, just added a test

> @mesejo I just updated the test, let me know if that is acceptable to you! I think using the handcrafted data will make it more clear what we are...

@NickCrews, I think it is because of the memtable. The following works for the Druid backend: ```python @pytest.mark.parametrize( "method,expected", [ pytest.param(lambda col: col.first(order_by="bigint_col"), 0, id="first_asc"), pytest.param(lambda col: col.last(order_by="bigint_col"), 9, id="last_asc"),...