Brian Merrell

More ergonomic support for graceful shutdown

40

[Edit: This issue started as a discussion of the API for cancel scope shielding, motivated by @merrellb using it to catch `Cancelled` errors and do clean up activities like sending...

Add fit_predict to FactorizationMachine

3

Although required (and now overridden) by mcmc, having this method always present makes it easier to test multiple solvers with minimal code changes

MCMC vs ALS

6

I have tested three approaches to regression on the Movielens 1M dataset: properMCMC - Passing the test data to `fit_predict` badMCMC - Passing empty test data to `fit_predict` and then...

Assertion failed when fitting with l2_reg_w=0 l2_reg_V=0

3

When fitting als.FMRegression with l2_reg_w=0 or l2_reg_V=0 I get the following assertion failure: ``` Assertion failed: (isfinite(new_V_fl) && "V not finite"), function sparse_fit, file ffm_als_mcmc.c, line 218. Abort trap: 6...