Memet Bilgin
Memet Bilgin
@BeyondEvil I've done a full feature including documentation upate in the PR #311. Let me know if you have any concerns. Thank you.
Hey, thanks @christiansandberg. That looks quite nice at a glance. I will review it when I get some cycles.
@tuxillo fyi, I'm using my forked project in production. I haven't published that project on terraform specifically because I want to keep the noise ratio down, but if you so...
I am working on a PR for this (@dmacvicar) I too see an important need for this: when writing modules, I may make use of virsh on multiple bare metal...
@SimonWoidig : fyi, this feature is completed in #1059, and merged to production branch on memetb/terraform-provider-libvirt fork project. You will have to build on your own though.
@dmacvicar I'm open to name by consensus. Reason for my chosing nodeinfo is because of the `virsh` command itself: ``` $ virsh help host Host and Hypervisor (help keyword 'host'):...
That sounds good. I will get these updates done sometime this week. We should at least move these conclusions over to #1073 comment thread for posterity.
My bad, this appears to have been merged in #1042 - after I started the feature, before I pushed this PR.
I've made this a draft until the issue #1074 is discussed
Ok, cool. Fyi, there's definitely some inappropriate usage of log.Fatal in here as well, ;)