mehdivk comments

Results 14 comments of


                                            mehdivk

"indentLine will overwrite 'conceal' color with grey by default" doesn't work in tmux vim

Thanks @yifanchen for pointing to the solution 👍

Auto reconnect if writer failed to connect to NSQ

Is there any update about this issue and do you accept a PR for this one? I think this feature would be handy.

Connect Writer to multiple NSQ Daemons

:+1:

"Error: endY is out of range" when using widths that are slightly the same

Hi, I got same error. Here with some information ``` wdio-screenshot:image Use image processing library: GraphicsMagick +0ms wdio-screenshot:image Use image processing library: GraphicsMagick +0ms wdio-screenshot:image Use image processing library: GraphicsMagick...

"Error: endY is out of range" when using widths that are slightly the same

This log `{"startX":16,"startY":485,"endX":752,"endY":873}` is kinda accurate and points to the element that I have on page.

"Error: endY is out of range" when using widths that are slightly the same

And looking at height of the viewport, it makes sense why we get an error, `873` is greater than `758` ```json { "html":{ "scrollHeight":758, "clientWidth":768, "clientHeight":758, "offsetHeight":758, "scrollWidth":768 }, "window":{...

Fix: Do not complain when endY is bigger than document height

@zinserjan glad to hear that. I totally agree with the integration test for this scenario. As I mentioned I tried to run integration tests using `npm run test:local` and it...

Fix: Do not complain when endY is bigger than document height

@zinserjan I managed to run integration tests on Ububunu and all of them are passing. I also added two more integration tests for the new scenario and it works. Can...

Fix: Do not complain when endY is bigger than document height

@zinserjan let's park IE screenshots for now as it's not a big deal. I updated the example so it fails with the original code and passes with the change. The...

Fix: Do not complain when endY is bigger than document height

> Yes, this is right and that's the real issue here. Just disabling the endY > documentHeight check doesn't solve this. Indeed. > With broken you mean kind of incomplete,...