Meet Agrawal

Results 15 comments of Meet Agrawal

@Aariq I think this issue can be closed since it is resolved by #3169.

@infotroph , should we consider moving `regrid` and `grid2netcdf` to `data.remote` package to solve this one ?

What would be the best way to manage dependency on the `regrid` function here : https://github.com/PecanProject/pecan/blob/develop/base/visualization/vignettes/usmap.Rmd An import from `data.remote` for the function is a way (after making the shift)....

And an exactly same approach for this one https://github.com/PecanProject/pecan/blob/develop/base/visualization/vignettes/usmap.Rmd#L95-#L125 ?

The logs of [PEcAn.BIOCRO](https://github.com/r-universe/pecanproject/actions/runs/3353111973/jobs/5584238472) seem to have expired. So is the `failing test` being talked about here in `PEcAn.BIOCRO` package present in this file : [Link](https://github.com/PecanProject/pecan/blob/develop/models/biocro/tests/testthat/test-run.biocro.R) ?

#2098 closes this issue : )

Updated the link in #3099

To fix this one (according to points by @infotroph) : 1. Should we consider modifying `trait.lookup` function (by making it dependent on DB) or completely remove it ? 2. Should...

I would vote for the second solution (function coverage). This is because functions do have unit tests which get skipped on CI because they need an additional setup to execute...

@Min2who, thanks for showing your interest in contributing to the issue. I am working on improving our tests without which `covr` will always fail in CI. Just a side note...