Médi-Rémi Hashim comments

Results 15 comments of


                                            Médi-Rémi Hashim

feat(org unit tree): allow request customization

I'm converting this PR to a draft as after discussing with @HendrikThePendric we've agreed to implement these changes in the https://github.com/dhis2/approval-app repo.

Not helpful error message when doing a typo in labeled arguments

Looks like this issue was fixed in `v12.0.0-alpha.10`: https://rescript-lang.org/try?version=v12.0.0-alpha.10&module=esmodule&code=DYUwLgBA5uBcEAoBQEIHsAOYCWaB2APAOQBuAhsAK4gB8ANChAH4BmFwARmQMYDW8pCtQC8AfgaomAExAkAYuy58B5KiDEMAlBGE0IgtTsRkATlAAMdZm2CcevDcxnzF9sdt0QApCbIB3BAAiPEpbQM0kJAApAGcAOmA0KGRUGDAU1AhAmKkWQIBaGgBJPDA4lhM0AFsAZTATbDwoQoB5LFw8OKqyDAQAfR09QLJc8IlM6RAWBVslB2zR8ckbOz5hBbzxzS0kIA

Document regex literal syntax

Potentially also update [%re syntax lookup](https://github.com/rescript-association/rescript-lang.org/blob/52ac33669f091fc769b1f6098b87f2a304ae815e/misc_docs/syntax/extension_regular_expression.mdx) to recommend literal syntax instead?

Refactor wish list

We probably want to switch from `TextDocumentSyncKind.Full` to `TextDocumentSyncKind.Incremental` (see ["Incremental Text Document Synchronization"](https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#incremental-text-document-synchronization) from the language server extension guide) and use VS Code's `TextDocuments` documents manager instead of rolling...

Recursive type definition breaks @unboxed

This was fixed by https://github.com/rescript-lang/rescript/pull/7320

Completions defined in `editor.autocomplete` don't work on type aliases

Preferably, the type alias would be transparently converted to the type it points to. But I would also be fine with the compiler emitting a warning like `Invalid editor.autocomplete value:...

Bindings where `@scope` has same name as module can result in runtime errors

Ah I didn't read the breaking changes section of `v12.0.0-alpha.1` carefully enough - I see now that since https://github.com/rescript-lang/rescript/pull/6831 we're not escaping browser globals anymore. I'll update this issue title...

Speed up `npm install` step on Linux ARM runners

[8s for `Run npm ci` in this PR](https://github.com/rescript-lang/rescript-vscode/actions/runs/15139474539/job/42559375565?pr=1098) vs [6m 40s for lastest merged PR](https://github.com/rescript-lang/rescript-vscode/actions/runs/15137696086/job/42553358219)

Update opam install command to correct flag

Is it possible you're using `opam` version 2.1.x or below? `--with-dev-setup` was introduced in opam v2.2.0, released July 2024: https://opam.ocaml.org/blog/opam-2-2-0/#Major-change-with-dev-setup When I initially followed the setup steps, I ran into...

Pass existing location to children prop

@nojaf I've tested this PR on my project and it fixes the issues I encountered :tada: Thanks for fixing this :pray: