Michael Doube

Results 36 comments of Michael Doube

Anisotropy uses a similar `ExecutorService` approach to multithreading and includes a `shutdownAndAwaitTermination()` method that appears to clean up old threads. https://github.com/bonej-org/BoneJ2/blob/da5aa63cdc15516605e8dcb77458eb34b0f00b85/Modern/wrapperPlugins/src/main/java/org/bonej/wrapperPlugins/AnisotropyWrapper.java#L380 Fractal Dimension may be using a messy approach to...

Fixed by calling `shutdown()` on the `ExecutorService` in `net.imagej.ops.morphology.outline.Outline` and `net.imagej.ops.topology.BoxCount` ![Screenshot from 2021-08-13 17-38-22](https://user-images.githubusercontent.com/87103/129337757-ac42faa6-c9c6-4782-821c-cc73fe5f8389.png)

PR #624 should be applied as well becuase it has a better threading model for `Outline`

The offending methods in this example are: `-> at org.bonej.wrapperPlugins.CommonWrapperTests.test2DImagePlusCancelsPlugin(CommonWrapperTests.java:222)` ```java static void test2DImagePlusCancelsPlugin( final Gateway imageJ, final Class commandClass) { // SETUP final UserInterface oldUI = imageJ.ui().getDefaultUI(); final UserInterface...

Looks like `getVisibleUI()` as per the error doesn't exist any more and is now `getVisibleUIs()` in the code. Digging into versions and build clashes.

This bug was introduced by `pom-scijava` between `35.1.1` and `36.0.0`. `35.1.1` is the last version that builds and tests OK.

Maven test reports for `pom-scijava 36.0.0.` [surefire-reports.zip](https://github.com/bonej-org/BoneJ2/files/12827478/surefire-reports.zip)

Thanks @ctrueden. I was thinking maybe we could try again to run these Mockito tests in the routine CI build via Github Actions. Richard pulled the slow tests out of...

I made a PR https://github.com/bonej-org/BoneJ2/pull/342 to see whether I could tweak the test configuration to make the wrapper tests run. They do, but I still get the same error even...

Just updated pom-scijava with the last Java 8 compatible Mockito so that wrapper tests run at all - they otherwise fail to build with an exception, on a new Eclipse...