Max Dhom

Results 23 comments of Max Dhom

> With this function i can start/stop the wallbox ;-) I still believe that this isn't an actual start / stop behavior. When I run your code trying to start...

my wallbox is in mixed mode and still no charging. I just saw that my phases where changed from 3 to 1 calling your start method. ![image](https://user-images.githubusercontent.com/30362954/156932356-665305fc-dd44-4968-9cd5-a416e5d7f8c2.png) That is how...

Ok, I made some tests. First it seems that my car wasn't accepting current, I now started charging via the cars app, now the wallbox is actually charging. But still,...

not sure what you mean with the controller method. I would not want to have a user of the library need to handle bytearrays just for toggle switches in the...

@vchrisb in this PR another 4-5 methods will be added to the e3dc client. Is there any plan on e.g. splitting some functionalities into subclasses, so that maintenance of code...

@othorg I think the PR is ready for reviewing. Can you please test it again with your system?

> Two suggestions only: Description in function toggle_wallbox_charging should (could) be: `Toggles charging of the wallbox via rscp protocol locally if sunModeOn = False` Is that really the case? I...

> @mdhom regarding #59 set_wallbox_max_charge_current... Do you think it's useful to build an exception, if the parameter value (int) is higher as the possible/permitted value in the S10 (I think...

> > > @mdhom regarding #59 set_wallbox_max_charge_current... Do you think it's useful to build an exception, if the parameter value (int) is higher as the possible/permitted value in the S10...

awesome, where did you find those infos / how were you able to reverse-engineer those values? I'll add the Keystate and discharge priority to this PR? **Edit:** reading key state...