mdagois
mdagois
Could you please add a quick summary of what problem the PR solves? I am not extremely familiar with the benchmark, and I have not touched BigWheels for a few...
> > Could you please add a quick summary of what problem the PR solves? > > I am not extremely familiar with the benchmark, and I have not touched...
> > > > Could you please add a quick summary of what problem the PR solves? > > > > I am not extremely familiar with the benchmark, and...
LGTM from a metrics perspective. I'll defer approval to people that own the project.
As an additional note, I used the `vkGetDeviceMemoryCommitment` function to make sure the memory was not committed when using the transient attachment. The results are that, for the allocation size...
> I think this looks good, but it might be missing a bit, which is the part that was undone in #7680. See also the "// DONT_CARE is critical here"...
> I think this looks good, but it might be missing a bit, which is the part that was undone in #7680. See also the "// DONT_CARE is critical here"...
With the *discard* storeop, I can see the committed memory stays at zero for the MSAA attachement for as long as the application runs. When switching to a *store* storeop,...
> @mdagois could you rebase the branch and resolve the conflicts? thanks! I rebased the branch. I also simplified the code in the constructor (like removing the `preferTransient` boolean) since...