Trevor McKeown

Results 16 comments of Trevor McKeown

Hi, I am having a similar problem. It seems like jinja2 doesn't like one of the values of my json variables. I am also on Windows 10 WSL. Below is...

Saw a few nit picks. I might be able to refactor this patch to use fewer files, by naming the snapshots in the test cases. WIP.

Thanks @bcoe. I will make the changes above and have a new commit in the next week.

@bcoe, Please review again.

Thanks for your comments on these. Some of the PRs did need to get closed. Unfortunately, this one is a prerequisite for #518 at the moment.

Everything looks good except the tests on node 14. The CI process fails with the following error: ```#!/bin/bash Run npm ci --engine-strict npm ERR! Cannot read property '@bcoe/v8-coverage' of undefined...

I am going to pull this back into draft mode. I noticed another module for spies that looks much easier to implement.

Reference to old PR (#436)