Ciprian Mindru comments

Results 49 comments of


                                            Ciprian Mindru

[GraphOptz] Merge Pad into CWQConv and Pool.

@jfix71 Can you review this?

[GraphOptz] Merge Pad into CWQConv and Pool.

ping

[GraphOptz] Merge Pad into CWQConv and Pool.

Ping.

[GraphOptz] Merge Pad into CWQConv and Pool.

@jfix71 Any other comments on this PR?

[GraphOptz] Merge Pad into CWQConv and Pool.

Ping.

[GraphOptz] Merge Pad into CWQConv and Pool.

ping

[ONNXModelLoader] Support for LogSoftmax operator is missing

@antimora Don't worry about it. Glow was (also) my first ever C++ real coding project. It took a while to get acquainted with Glow and C++ but in the end...

[ONNXModelLoader] Support for LogSoftmax operator is missing

Hi @muhdmud. In my knowledge this is not done. Any contribution to this is warmly welcomed 😄

[ONNXModelLoader] Support for LogSoftmax operator is missing

@muhdmud You can find some general guidelines [here](https://github.com/pytorch/glow/blob/master/docs/NewOperators.md). The main steps would be in this case: 1. You should define a new node LogSoftmax and define a lowering logic [here](https://github.com/pytorch/glow/blob/master/lib/Optimizer/Lower/Lower.cpp)...

[ONNXModelLoader] Support for LogSoftmax operator is missing

@muhdmud You should submit a single PR with everything. Thanks!