Milind Changire

I wonder whats the `cat /proc/mounts | grep ceph` output where the mount succeeds at the command-line

> > I wonder whats the `cat /proc/mounts | grep ceph` output where the mount succeeds at the command-line > > /proc/mounts has the record to the cephfs mount as...

> General comment: > > The typedef for the shared_ptr declare in LogSegment.h: `using LogSegmentRef = std::shared_ptr;` I didn"t find a way to enable forward declaration for it. So I'd...

> > @lxbsz What happens to the quota which is already set ? > > The size from `df` output will always be rounded down to 4MB, for example, if...

@dparmar18 some description about what the problem is and why this solution of evaluating strays is beneficial would be prudent

@dparmar18 I think this could be done better in `Server::handle_client_rmsnap()` or `MDSRankDispatcher::tick()`. This would avoid the requirement of the out-of-band scrub path invocation.

> > @mchangir > > > @dparmar18 I think this could be done better in `Server::handle_client_rmsnap()` > > > > > > Unsure about `Server::handle_client_rmsnap`, will definitely check it out....

> I've tested this myself on a cluster exhibiting this problem. Since this was an upgrade scenario, was the cluster cold-started after a few scheduled snapshots after the upgrade to...

> No changes done in the last push, removed unwanted 'mds:' from commit message If you've mentioned `mds` in the commit message title, then you don't need to mention `server`...

> > LGTM @vshankar fyi > > Just a small question to @thmour If rctime is updated manually, that rctime has to bubble up to the root dir or snap-root...