Tony Miller

Results 130 comments of Tony Miller

Not sure if I should take anything from this branch as well https://github.com/twokul/ember-lazy-image/pull/58

I've almost got the tests passing, down to two failures: ``` Integration | Component | lazy-image: it leverages cache Expected: | { "viaplaceholdercom150": true } -- | -- {} {...

Fixed the image classes test. I realized it was checking the class of the tag, not the component's tag. The cache test should be working now, but still seems a...

I'd be happy to take it over as well. https://github.com/mcfiredrill/ember-lazy-image/ @twokul

I haven't had any luck getting a class based validator to work according to the README instructions either.

> Does https://github.com/emberjs/data/pull/8008 fix this issue too for anyone? I did not see it anymore. I've been bitten by this multiple times, if this fix works I'd appreciate a backport...

I don't have much to say about the details but a 3x speed improvement is going to improve developer life significantly, this sounds great. :100:

> Even though yarn and pnpm may be quicker/better, as long as the majority of the JS ecosystem is using npm, I think ember should stick to it as the...

I'd be open to hearing arguments for yarn 3, however > getting modern yarn isn't even easy. It's not even called yarn, but "yarn berry", which is more complicated to...