mcclumpherty

Gyoku.xml() method is not idempotent

3

The xml method does not behave as I would expect as it modifies the hash that is passed into it. Moreover, it modifies elements within the hash as it proceeds....

Port number display is not entirely useful since it isn't guaranteed to be unique

1

In the `TemperDevice` class, the ports attribute is initialised to the port number. The naming here is somewhat contradictory - namely that a plural ('ports') is assigned a single number....