Maria Basmanova
Maria Basmanova
@chronoxor Is this something you can advise on? I'm also seeing that the project has no PRs open or closed. I wonder how bugs are fixed and improvements being made.
@PraneshASP I don't think you can compile this so easily. Try following instructions in https://github.com/chronoxor/CppServer/#how-to-build
@PraneshASP Would you run ./unix.sh again, capture all of output and share here?
What is your cmake and g++ versions? ``` $ cmake --version cmake version 3.16.4 CMake suite maintained and supported by Kitware (kitware.com/cmake). $ g++ --version Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1 Apple...
@Mionsz Let me import and land this. Next time, don't hesitate to ping earlier.
@karteekmurthys Kartheek, would you squash all commits and rebase onto latest?
@aditi-pandit Aditi, I'm getting an error: "This diff is either too old, or sits on an old base revision, making it unsafe to land - try rebasing first." Would you...
@zhejiangxiaomai Thank you for clarify the PR title. It reads "support avg function based on row_construct" now. Would you also update the PR description to explain what does that mean...
@zhejiangxiaomai I spent some time running and debugging Substrait conversion code. First, I ran into this error: ``` error: 'args' is deprecated [-Werror,-Wdeprecated-declarations] ./velox/substrait/proto/substrait/algebra.pb.h:11241:3: note: 'args' has been explicitly marked...