Mayur comments

Results 25 comments of


                                            Mayur

fix: primary keys need not to be integers, to serialize them is safer to use str() than int()

@mapio I think Daniel's style on merging in this repo is bit different, he will approve all finalised prs and just before cutting a release he will rebase on master...

Virtual Dataset becoming Physical after a while

couldn't repro on current master.

Tree chart: Add option to sort nodes by ID or NAME column

don't think echarts provide this option.

Tree chart: Add option to sort nodes by ID or NAME column

this should be a feature request in discussion.

PivotTable doesn't corrently count total (SUM) in case of division metric

use pivottable 2, this one is deprecated and has few bugs which are less likely to be fixed in the future.

PivotTable doesn't corrently count total (SUM) in case of division metric

ahh sorry missed it.

PivotTable doesn't corrently count total (SUM) in case of division metric

I think this is correct behaviour to show sum of column instead of checking how its calculated, I might be wrong.

Couldn't downlaod csv in given location

not reproducible on master, I am able to download csv of table chart. if you could provide superset version, chart version someone will be able to help.

perf(dashboard): Virtualization POC

Awesome feature, tested locally.

Annotations intermittently fail to display for many chart types

couldn't reproduce in latest master (last commit sha: 8f74e46d45ca94f5656f7b881f1096c16657c829) used time series line chart, superset annotation for interval. ![Screenshot from 2022-10-12 23-42-42](https://user-images.githubusercontent.com/12967587/195417339-c7dfd668-9cdf-4ad7-a23c-b4cfe89c7854.png) possible to test this on latest master?