Maximilian Moehl
Maximilian Moehl
The new response for route-service timeouts would be: ``` 504 Gateway Timeout: Failed to validate Route Service Signature: route service request expired ```
I ran the tests and got the test case related to my change green again, but there are still lots of other tests that were already failing.
Thanks for the review! 1. Will check that, but if I remember correctly it returns a 502 in that case 2. Didn't catch that, will update this section as well...
I'm not sure how to continue with this. The main issue right now is that we cannot mock the request tracer. This hasn't been an issue until now because we...
Yes, that pretty much catches the issue I'm facing. The overlap is mainly concerned with the `isRetriable` function which layers two ifs on top of the existing classifiers. I was...
@dmikusa we do now have the documentation but since the value in gorouter cannot be changed I still think it would make sense to align the buildpack and gorouter timeout....
Hi @geofffranks, sorry i totally forgot about this PR 😓 I changed the second occurrence you pointed out and adapted the unit-tests, they are now passing locally (`./scripts/run-unit-tests-in-docker gorouter`). I...
Would this help resolve #247 or is that a different issue?
I made this a draft because I noticed that it does not fix the issue in all scenarios. Running a loop with one `RuleAdd` and `Flush` still causes the buffer...
We can't merge this as-is since it will be doing the TLS handshake in [the main accept loop](https://cs.opensource.google/go/go/+/refs/tags/go1.22.1:src/net/http/server.go;l=3255). A slow TLS handshake could therefore block gorouter from accepting other connections...