Max Milton
Max Milton
TreeWalker `nextSibling`/`previousSibling` throw error when `currentNode` is set to another DOM tree
When TreeWalker is walking a DOM tree it was not initialised with it throws an error when `nextSibling`/`previousSibling` are called and it reaches the (other DOM tree's) root. Although [the...
Fixes #558 Add additional check to TreeWalker `nextSibling` and `previousSibling` to make sure `this.currentNode.parentNode` exists. Although this fixes my immediate issue, there are plenty of other checks against `this.root` throughout...
Currently a bunch of tests are failing which need to be fixed. The navbar component also got heaps of upgrades but didn't get tests to cover new logic. Similar thing...
In the theme of trying to make everything in this project fast, it would be nice if the unit/functional tests were also made faster. Although [jsdom](https://github.com/jsdom/jsdom) is widely used and...
Now that #1151 is merged we have bookmark folder popup position that is "good enough" for general use but the experience is not ideal in all scenarios. For context, "top...
Before we can publish a new version on the Chrome Web Store it's now required to have screenshots and privacy info. This would be a good opportunity to rewrite the...
After the fixes for #1122 we are in a position where bookmark popups are shown/dismissed at the right time, other than the scenario where a folder popup is open and...
Another issue arising from PR , in order to get the best possible performance, favicons are loaded directly from the Chrome favicon cache (`chrome://favicon/`). This is amazing for performance because...
Once PR https://github.com/MaxMilton/new-tab/pull/273 is merged, there is an issue with the menu icon overlapping the search input because the menu icon is now `position: fixed`.
**Describe the bug** Attempting to use a `Browser` instance throws a `TypeError` when trying to call the browser instance's `close` method. This only occurs with `bun` and not with `nodejs`....