Maximilian Fridrich
Maximilian Fridrich
While developing, I recommend building Asterisk with the `--enable-dev-mode` flag (`./configure --enable-dev-mode`).
> This change adds remaining streams of second topology to the joint topology. Isn't that what `operation: union` does? Have you tried doing `codec_prefs_* = ..., operation: union, ...`?
That makes sense, sorry for the confusion.
Looks good to me. I also ran the [ACN testsuite PR](https://github.com/asterisk/testsuite/pull/20) with it and there's no issues. @btriller Could you describe a scenario (with configured endpoint settings, SDP offers and...
Thank you for providing the test case! > Without this PR's change, Asterisk emits a reINVITE after answering to alice (caller) You're right, I can reproduce that. With your change...
> Was removal intended? Yes, that was intended. This change broke many test cases of `channels/pjsip/codec_negotiation` while your provided test case was still failing. I haven't managed to make that...
cherry-pick-to: 18 cherry-pick-to: 20 cherry-pick-to: 21
Oops, thank you!
cherry-pick-to: 21 cherry-pick-to: 20 cherry-pick-to: 18
This PR must be tested with the corresponding testsuite PR which adds 48 tests to test the codec negotiation: - https://github.com/asterisk/testsuite/pull/20 Further, 10 tests were adopted to reflect the new...