Maxime Chevalier-Boisvert
Maxime Chevalier-Boisvert
An important thing to check, after fixing the bug, is that the correctness and performance of the bot is not affected. See the [eval_bot](https://github.com/mila-iqia/babyai/blob/master/scripts/eval_bot.py) script. @chitwansaharia is this bug blocking...
@chitwansaharia ?
Hello. The first array is the object type, the second is the color, and the third is a flag indicating for example if a door is open or not: https://github.com/Farama-Foundation/gym-minigrid/blob/master/gym_minigrid/minigrid.py#L238
Hi @tudor-berariu. I think you are correct. It seems to me it should be safe to just change the default signature to `def seed(self, seed=None)` and not check `if seed...
I would accept a PR if you'd like to fix that :)
I like that you've added tests. I actually implemented the bit depth reduction for my own variant and this is the code I had: ``` // Clamp the input in...
Hello Greg. Sorry for the slow response, got busy with life. I've tried the PR and added comments.
Yeah. I've been wanting to add cycle detection for a little while but never got around to it 😅 Ideally, as soon as you add a new connection that creates...
Added some notes as to how I think this can be implemented.
Hi Greg! I'm just going based on the existing BitCrush plugins I've seen. They typically have options for both bit depth and sample rate. I think it could produce a...