Max Fortun

Results 19 comments of Max Fortun

@jbonofre I am not sure I understand. This is a Redis storage layer, not LevelDB. Are you saying that Redis is of no interest as a storage layer? We have...

@mattrpav , you are correct, the contribution is just a scheduled message store that does not change any default behavior and needs to be specifically configured within a broker block...

Well, this is an optional add-only change. As it does not modify any of the existing behaviors, and as such is not compromising any of the existing functionality. So I...

Clarification: The code was copied and augmented with Redisson client from InMemoryJobScheduler (https://github.com/apache/activemq/tree/main/activemq-broker/src/main/java/org/apache/activemq/broker/scheduler/memory) The dir/file structure/layout were modeled after leveldb, as I thought that's how optional components are packaged into...

Thank you, just created the issue: https://issues.apache.org/jira/browse/AMQ-8274 > On May 21, 2021, at 12:42 PM, Matt Pavlovich ***@***.***> wrote: > > > Hello @maxfortun , thanks for the PR. Will...

I am not sure why maven tests are failing. My changes were only to a front end javascript file. Is this a blocker for a merge?

@ChristopherSchultz thank you for your meticulous review, I'll make the adjustments. As far as the "why". We are deploying hundreds of containerized apps that need the same tomcat behavior and...

> Thank you for your contribution. I have a few comments: > > 1. The javadoc was copy/pasted and inaccurate: both classes claim to serve JSPs for errors, and neither...

> This feels more like a custom ErrorReportValve rather than something that would ship with Tomcat. I do agree with Chris that a lot (all?) of this functionality could be...