Max Brunsfeld

Results 494 comments of Max Brunsfeld

Right now, this package assumes that the repl is running locally; it reads the standard `.nrepl-port` file to determine its port. We could add a command for opening a connection...

Hey @ilkka, yeah I obviously haven't put much time into this package lately. I'm not even sure if it works with the latest Atom. I love `vim-fireplace` too, and I...

It's possible, but might be complicated. We might have to re-assign `*out*` to an alternative `OutputStreamWriter` the first time you connect. This might affect other clients of the same nrepl...

Hey Matt! This makes a lot of sense to me, from my understanding. I would merge such a PR, although @joefitzgerald is now the primary author and maintainer of this...

@orktes :wave: It looks like this package was patching some of the internals of Atom's `TextEditor` objects, and these internals have changed recently. The `.languageMode` sub-object was removed in https://github.com/atom/atom/pull/15713....

> I think I found the cause of this issue. I think tree-sitter has problems with reusing trees that are very "flat", i.e. trees where most nodes have a lot...

Ok, I can reproduce the problem from the command line. I believe the problem is a certain conflict in your grammar, between `_soft_line_break` and `_paragraph_end_newline`. It causes every paragraph to...

I think it's probably ok for emphasis to have that conflict, since most (all?) top-level nodes in the document are not emphasis nodes.

I'm open to adding APIs to `atom.config`, but I'm not quite understanding your `excludeScope` proposal. Currently, the `scope` option does not take a *selector* (e.g. `.text.html.php.blade`); it takes a [`ScopeDescriptor`](https://github.com/atom/atom/blob/master/src/scope-descriptor.coffee)...

> We just need a mechanism to get the value for a property that excludes the exact scope name itself, but would allow the less specific (more generic?) scoped property...