Max Bergmark comments

Results 11 comments of


                                            Max Bergmark

Check if last pressed key is part of hotkey combination

@friendlymatthew All good suggestions, I fixed them immediately. I also noticed that #127 causes conflicts with my changes. I changed my code to also use `key()` instead of `code()`, and...

Check if last pressed key is part of hotkey combination

@friendlymatthew Good suggestion, I'll clean it up. A quick note: I got a bit worried that I'd broken something: Due to #127, there might need to be some updates to...

Check if last pressed key is part of hotkey combination

@friendlymatthew Sounds like a good plan, it's better practice to have separate PRs.

Check if last pressed key is part of hotkey combination

@friendlymatthew I reverted the past two commits

Check if last pressed key is part of hotkey combination

Thank you for approving this! If you merge it (I don't have write access) you could re-use the logic for using either the key or code: ```rust #[cfg(not(feature = "ssr"))]...

Key is re-triggered when other key is let go

I did some additional testing by enabling the "debug" option for the crate. From there, it is quite apparent what's happening. Here, I started by pressing arrow up, and then...

Key is re-triggered when other key is let go

Quick update: I think I have a fix for the problem. I just replaced the existing hashmap containing all keypresses with a struct: ```rust #[derive(Debug, Default, Clone)] #[cfg_attr(feature = "ssr",...

Key is re-triggered when other key is let go

I created a PR, and tested the functionality locally using the sudoku app I linked above. From my testing, all of these things work as expected: 1. Single key presses...

Conditional tailwind classes are not automatically included

Good suggestions! I'll try them out, and see what the outcome is.

Conditional tailwind classes are not automatically included

@gbj As you suspected, this doesn't sound like it is a Leptos problem, but more of a Tailwind problem. Still, I would argue that it's a bit confusing that adding...