Max Alekseenko
Max Alekseenko
Hi, I agree with both of you, @patitonar and @varasev. So I would like to hear the opinion of @akolotov
Approximate sizes: |Contract | Size (kb) | | ------------- | :---: | | ForeignAMBErc677ToErc677 | 14.5 | | ForeignAMBErc677ToErc677RelativeDailyLimit | 16 | | HomeAMBErc677ToErc677 | 14.5 | | HomeAMBErc677ToErc677RelativeDailyLimit |...
@varasev, ok, I will start working on it
I moved all logic related to limits to external contract and removed all duplicate contracts with ending `...RelativeDailyLimit`. Also I optimized some `initialize` methods Tests are not yet updated Comparison...
> @maxaleks OK, so currently everything is ready in this PR except unit tests, right? Except unit tests and deployment scripts. Possibly some logic will be changed during the tests...
> @maxaleks can you please resolve the merge conflicts? Done
@patitonar ok, thanks!
> Can you check the merge one more time? For example, I have found that `_relayTokens` was removed from the `ForeignBridgeErcToNative.sol` by some reason. I removed `_relayTokens` because it is...
> Also I see that the tests were failed for the latest changes in the branch -- could you elaborate the root cause of fails? Could you rerun the task...
> They are different as far as I see Sorry, I missed it when fixing merge conflicts